Change in libosmo-sccp[master]: osmo_sccp_simple_client_on_ss7_id(): Allow set internally proper IPv4...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Oct 7 11:28:40 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/25689 )

Change subject: osmo_sccp_simple_client_on_ss7_id(): Allow set internally proper IPv4/v6 default hosts
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmo-sccp/+/25689/1/src/osmo_ss7.c 
File src/osmo_ss7.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/25689/1/src/osmo_ss7.c@1257 
PS1, Line 1257: oterwise
otherwise


https://gerrit.osmocom.org/c/libosmo-sccp/+/25689/1/src/osmo_ss7.c@1279 
PS1, Line 1279: !(rem_has_v4 && !rem_has_v6)
Can it be that no remote addr is set and no local addr is set? if that is the case, it seems that it will because of rem_has_v6 == false, use "0.0.0.0" for the local addr even if IPv6 is supported.

So maybe it makes more sense to switch the "if (!asp->cfg.local.host_cnt)" and "if (!asp->cfg.remote.host_cnt)" blocks?

I know that this is existing code that was only moved around in this patch, so if this is a problem it should probably be fixed in a follow up patch.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/25689
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I82e203612571b7651d758d8148661f706a1642ba
Gerrit-Change-Number: 25689
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Oct 2021 11:28:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211007/faee1dd0/attachment.htm>


More information about the gerrit-log mailing list