This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25691 ) Change subject: load_indication.c: Avoid sending if CCCH is still not operational ...................................................................... load_indication.c: Avoid sending if CCCH is still not operational It makes no sense to transmit load information if the channel is still not operational. This solves errors messages seen in osmo-bsc. Related: OS#4872 Change-Id: I7ddda9776158eed0694df9e458f3f91df90bf674 --- M src/common/load_indication.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/load_indication.c b/src/common/load_indication.c index 69af9c6..d5b76ea 100644 --- a/src/common/load_indication.c +++ b/src/common/load_indication.c @@ -41,6 +41,10 @@ struct gsm_bts *bts = data; unsigned int pch_percent, rach_percent; + /* It makes no sense to send Load Indication if CCCH is still disabled...*/ + if (bts->c0->ts[0].mo.nm_state.operational != NM_OPSTATE_ENABLED) + goto retry_later; + /* compute percentages */ if (bts->load.ccch.pch_total == 0) pch_percent = 0; @@ -73,6 +77,7 @@ bts->load.rach.access); } +retry_later: reset_load_counters(bts); /* re-schedule the timer */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7ddda9776158eed0694df9e458f3f91df90bf674 Gerrit-Change-Number: 25691 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211007/f4c8bb27/attachment.htm>