Change in osmo-bts[master]: Move lchan specific code from gsm_data.h to lchan.h

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Oct 7 10:21:18 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25697 )

Change subject: Move lchan specific code from gsm_data.h to lchan.h
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/25697/4/include/osmo-bts/gsm_data.h 
File include/osmo-bts/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bts/+/25697/4/include/osmo-bts/gsm_data.h@a80 
PS4, Line 80: struct gsm_lchan;
Can be removed now.


https://gerrit.osmocom.org/c/osmo-bts/+/25697/4/include/osmo-bts/gsm_data.h@a164 
PS4, Line 164: /* MS/BS Power related measurement averaging algo */
We may want to move power control related stuff to power_control.h. These structures are also part of 'struct gsm_bts' and 'struct gsm_bts_trx', so having them in lchan.h is not 100% correct from the architectural point of view.


https://gerrit.osmocom.org/c/osmo-bts/+/25697/4/src/common/rsl.c 
File src/common/rsl.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25697/4/src/common/rsl.c@392 
PS4, Line 392: 			       const uint8_t *link_id, const struct msgb *orig_msg)
Unrelated.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25697
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6424dcbd2e329fc1a516f8886359554ed7e9487e
Gerrit-Change-Number: 25697
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Oct 2021 10:21:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211007/2b1f7d64/attachment.htm>


More information about the gerrit-log mailing list