This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25694 ) Change subject: Power-Loop: Fix LOG when Keeping MS Power level at the same level. ...................................................................... Patch Set 2: > OK, I don't see how it makes sense to print the power level we "request", when we are not actually "requesting" anything. For sure we are. We are always requesting a given MS Power level to the MS. MS doesn't necessarily need to support that power level afair, it should then use the one immediately below (above in dBm) which is supported IIRC. See my previous comment, I believe the fix should be using: > state->current, current_dbm Before the "ignore" flag was added, this was not needed because well, the value used in current code and the changes I propose were basically the same. Please give it a try and submit the fix if it improves the situation. Another topic to improve would be the "curr %d" part of the message, which prints the currently used Power level by the MS on that period (Announced MS Power Level). "curr" is a bit vague here, specially since it conflicts with our naming "current" we use in variable name for the "currently requested MS Power level". Maybe "announced %d" would be clearer there too, feel free to submit an extra patch with that fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I002b708cfda60371f57e32617e7ee33cb41c42f7 Gerrit-Change-Number: 25694 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Wed, 06 Oct 2021 14:36:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211006/48840442/attachment.htm>