Change in osmo-msc[master]: Add support for LCLS to the MSC

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/24236 )

Change subject: Add support for LCLS to the MSC
......................................................................


Patch Set 7:

(5 comments)

https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/src/libmsc/msc_vty.c 
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/src/libmsc/msc_vty.c@503 
PS7, Line 503:       "lcls-disable",
Maybe use DEFUN_ATTR(...., CMD_ATTR_IMMEDIATE). There are new variants of DEFUN which allow to indicate when a config change takes effect. There is also an DEFUN_USRATTR() that allows to specify user defined attributes. bsc_vty.c is a good example to see how to use it. See also command.h in libosmocore.


https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/src/libmsc/msc_vty.c@506 
PS7, Line 506: 	gsmnet->lcls_disable = 1;
maybe use "true" - its also declared as bool


https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/src/libmsc/msc_vty.c@513 
PS7, Line 513: {
This probably should probably be "Globally enable LCLS..." ?

I still would prefer to have "lcls-enable" and "no lcls-enable" commands.


https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/src/libmsc/msc_vty.c@514 
PS7, Line 514: 	gsmnet->lcls_disable = 0;
same here, better use "false"


https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/src/osmo-msc/msc_main.c 
File src/osmo-msc/msc_main.c:

https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/src/osmo-msc/msc_main.c@261 
PS7, Line 261: 	net->lcls_disable = 1;
better use "true"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/24236
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I705c860e51637b4537cad65a330ecbaaca96dd5b
Gerrit-Change-Number: 24236
Gerrit-PatchSet: 7
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Oct 2021 10:14:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211006/542e1ede/attachment.htm>