Change in osmo-bts[master]: Power-Loop: Fix LOG when Keeping MS Power level at the same level.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Oct 5 19:21:52 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25694 )

Change subject: Power-Loop: Fix LOG when Keeping MS Power level at the same level.
......................................................................


Patch Set 2: Code-Review-1

That's not correct. We want to print the power level we request, not the one the MS was using. You already have the information you want in ms_power_lvl.
I guess you see a difference there because it falls into the ignore=true case there. I wanted to print "Ignoring" instead of "Keeping" in that case, but fixeria voted against it because he said it was confusing. If "Ignoring" is printed, then the other values make sense imho.

If you still don't want to print "ignoring" in that case, then, the 2 params you are changing should be set to instead:
"""
state->current, current_dbm
"""


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25694
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I002b708cfda60371f57e32617e7ee33cb41c42f7
Gerrit-Change-Number: 25694
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Oct 2021 19:21:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211005/be57c9a5/attachment.htm>


More information about the gerrit-log mailing list