Change in osmo-bts[master]: Power-Loop: Fix LOG when Keeping MX Power level at the same level.

[keith]

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/25694 )


Change subject: Power-Loop: Fix LOG when Keeping MX Power level at the same level.
......................................................................

Power-Loop: Fix LOG when Keeping MX Power level at the same level.

The log message used the calcuated NEW power level and dB that would have been set
if the conditions to actually change MX Power had been met.

It was slightly confusing, resulting in erroneuos LOG messages such as:

    Lowering MS power control level 18 (7 dBm) => 19 (5 dBm)
    Keeping MS power at control level 19, 3 dBm

Change-Id: I002b708cfda60371f57e32617e7ee33cb41c42f7
---
M src/common/power_control.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/94/25694/1

diff --git a/src/common/power_control.c b/src/common/power_control.c
index 8f5ce37..d81a440 100644
--- a/src/common/power_control.c
+++ b/src/common/power_control.c
@@ -287,7 +287,7 @@
 		LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "Keeping MS power at control level %d (%d dBm): "
 			  "ms-pwr-lvl[curr %" PRIu8 ", max %" PRIu8 "], RSSI[curr %d, avg %d, thresh %d..%d] dBm,"
 			  " C/I[curr %d, avg %d, thresh %d..%d] dB\n",
-			  new_power_lvl, new_dbm, ms_power_lvl, state->max, ul_rssi_dbm, rxlev2dbm(rxlev_avg),
+			  ms_power_lvl, ms_dbm, ms_power_lvl, state->max, ul_rssi_dbm, rxlev2dbm(rxlev_avg),
 			  rxlev2dbm(params->rxlev_meas.lower_thresh), rxlev2dbm(params->rxlev_meas.upper_thresh),
 			  ul_lqual_cb/10, ul_lqual_cb_avg/10, ci_meas->lower_thresh, ci_meas->upper_thresh);
 		return 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25694
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I002b708cfda60371f57e32617e7ee33cb41c42f7
Gerrit-Change-Number: 25694
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211005/f346453a/attachment.htm>