This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25674 ) Change subject: rsl: prevent race condition during timeslot re-configuration ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/25674/2/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/25674/2/src/common/rsl.c@3258 PS2, Line 3258: msgb_free(msg); Its a bit difficult to track the ownership of the msg. Maybe a comment might help to understand why we may lchan->rsl_chan_activ = NULL all while at the same time we have a condition around msgb_free(msg). I guess this is because when rsl_rx_chan_activ(msg) is returning 1, the cycle just started over and rsl_rx_chan_activ(msg) populates lchan->rsl_chan_activ again. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia625c2827fca883ea712076706d5ef21ed793ba6 Gerrit-Change-Number: 25674 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Tue, 05 Oct 2021 09:10:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211005/50c3ee23/attachment.htm>