This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
keith gerrit-no-reply at lists.osmocom.orgkeith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/25675 )
Change subject: Implement basic Support for Global Call Reference.
......................................................................
Patch Set 2:
(3 comments)
This change is ready for review.
https://gerrit.osmocom.org/c/osmo-sip-connector/+/25675/2/src/sip.c
File src/sip.c:
https://gerrit.osmocom.org/c/osmo-sip-connector/+/25675/2/src/sip.c@116
PS2, Line 116: char gcr_hex[sizeof(call->gcr)*2] = {0};
> Not sure this kind of initializer for arrays is actually setting all values to 0, but only the first […]
Hi Pau, Thanks for taking a look at this! I'm aware it's full of issues. Not only in terms of coding, but also strategy. It's WIP.
But yes, how to do all this initialization and also getting the correct size for the osmohexdump dest buffer is something I have problems with.
https://gerrit.osmocom.org/c/osmo-sip-connector/+/25675/2/src/sip.c@125
PS2, Line 125: memcpy(gcr_hex, unknown_header->un_value, sizeof(gcr_hex));
> do you really need this gcr_hex intermediate variable and hence this memcpy? I guess you can simply […]
Ack
https://gerrit.osmocom.org/c/osmo-sip-connector/+/25675/2/src/sip.c@612
PS2, Line 612: char gcr_hex[sizeof(leg->base.call->gcr)*2] = { NULL };
> See my comment regarding memset. Furthermore, NULL char makes no sense as a char. […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/25675
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Id40d7e0fed9356f801b3627c118150055e7232b1
Gerrit-Change-Number: 25675
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Oct 2021 15:42:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/f185c075/attachment.htm>