Change in osmo-bts[master]: trx_provision_fsm: Drop unneeded reset of fields

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Oct 4 14:33:10 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25677 )

Change subject: trx_provision_fsm: Drop unneeded reset of fields
......................................................................

trx_provision_fsm: Drop unneeded reset of fields

Since recently, reset of all fields is already properly done in
trx_provision_reset().

Change-Id: I3e6bc8205704e425644507dd1f1b299dea4cd851
---
M src/osmo-bts-trx/trx_provision_fsm.c
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c
index 52736ad..758789d 100644
--- a/src/osmo-bts-trx/trx_provision_fsm.c
+++ b/src/osmo-bts-trx/trx_provision_fsm.c
@@ -584,7 +584,6 @@
 	struct phy_instance *pinst = l1h->phy_inst;
 	struct phy_link *plink = pinst->phy_link;
 	struct trx_prov_ev_cfg_ts_data* ts_data;
-	uint8_t tn;
 
 	switch (event) {
 	case TRX_PROV_EV_CLOSE:
@@ -594,11 +593,6 @@
 				trx_if_cmd_poweroff(l1h, l1if_poweronoff_cb);
 				plink->u.osmotrx.poweronoff_sent = true;
 			}
-			l1h->config.rxgain_sent = false;
-			l1h->config.maxdly_sent = false;
-			l1h->config.maxdlynb_sent = false;
-			for (tn = 0; tn < TRX_NR_TS; tn++)
-				l1h->config.setslot_sent[tn] = false;
 		} else if (!pinst->phy_link->u.osmotrx.poweronoff_sent) {
 			bts_model_trx_close_cb(pinst->trx, 0);
 		} /* else: poweroff in progress, cb will be called upon TRXC RSP */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25677
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3e6bc8205704e425644507dd1f1b299dea4cd851
Gerrit-Change-Number: 25677
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/168f2111/attachment.htm>


More information about the gerrit-log mailing list