Change in osmo-bts[master]: abis: fix memory leak in abis_oml_sendmsg()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Oct 4 12:44:05 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25671 )

Change subject: abis: fix memory leak in abis_oml_sendmsg()
......................................................................

abis: fix memory leak in abis_oml_sendmsg()

Change-Id: Ifc46b94b4540705f7d9b4678a7398158f3aaf7c5
Fixes: Iecd3c7cb96f5fff3b4c7e04c74e031df0f7a6987
---
M src/common/abis.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  dexter: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/abis.c b/src/common/abis.c
index f1fb10c..c0cd18c 100644
--- a/src/common/abis.c
+++ b/src/common/abis.c
@@ -324,6 +324,7 @@
 
 	if (!bts->oml_link) {
 		LOGP(DABIS, LOGL_INFO, "Drop Tx OML msg, OML link is down\n");
+		msgb_free(msg);
 		return 0;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25671
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifc46b94b4540705f7d9b4678a7398158f3aaf7c5
Gerrit-Change-Number: 25671
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/f76d2c37/attachment.htm>


More information about the gerrit-log mailing list