This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25677 ) Change subject: trx_provision_fsm: Drop unneeded reset of fields ...................................................................... Patch Set 2: > Patch Set 2: > > trx_provision_reset() is only invoked from st_open_poweroff_on_enter(). > It is not clear to me how the fields are always reset. > > - the part that invokes a poweroff is only one branch of this function. > - the poweroff may fail for some reason, so that st_open_poweroff_on_enter() isn't called? > > are you sure about this? Yes it fine since from TRX_PROV_ST_OPEN_WAIT_POWEROFF_CNF one can only move to CLOSED and the back to OPEN_POWEROFF. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3e6bc8205704e425644507dd1f1b299dea4cd851 Gerrit-Change-Number: 25677 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 04 Oct 2021 11:47:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/06de2469/attachment.htm>