Change in osmo-bsc[master]: fix TSC / TSC Set used for Handover

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Oct 4 11:01:02 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25659 )

Change subject: fix TSC / TSC Set used for Handover
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/25659/2/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/25659/2/include/osmocom/bsc/gsm_data.h@629 
PS2, Line 629: 	bool ta_known;
> Idea for a separate change: use 'struct optional_val' here too.
would make sense, but maybe not worth the effort.

(the main reason i added struct optional_val for tsc was that i can do

  foo.tsc = bar.tsc;

to copy both value and flag at the same time. Well, and have less comments.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25659
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iae20df4387c3d75752301bd5daeeea7508966393
Gerrit-Change-Number: 25659
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Oct 2021 11:01:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/c126f440/attachment.htm>


More information about the gerrit-log mailing list