This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25659 )
Change subject: fix TSC / TSC Set used for Handover
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/c/osmo-bsc/+/25659/2/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/25659/2/include/osmocom/bsc/gsm_data.h@144
PS2, Line 144: struct optional_val {
> I personally don't think it really make sense to have this kind of stuff in libosmocore.
IMHO such a define would be bloat, and it'd be more stuff ctags doesn't find.
https://gerrit.osmocom.org/c/osmo-bsc/+/25659/2/include/osmocom/bsc/gsm_data.h@145
PS2, Line 145: use
> agree, "valid" sounds like a better name here.
for the use i have in mind, it's not interesting whether the value is valid or not, the interesting bit is whether the code should use the value or not.
val == 0 would be a valid value, but if the flag is false, then osmo-bsc should rather use a different, default value. So I don't agree with "valid".
"present" would be a better match. We also use "present" in BSSMAP message structs for optional IEs.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25659
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iae20df4387c3d75752301bd5daeeea7508966393
Gerrit-Change-Number: 25659
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Oct 2021 10:50:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/55de7f51/attachment.htm>