Change in osmo-bsc[master]: assignment_fsm: Check for conn->lchan

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Oct 4 09:30:24 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25676 )

Change subject: assignment_fsm: Check for conn->lchan
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/25676/1/src/osmo-bsc/assignment_fsm.c 
File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25676/1/src/osmo-bsc/assignment_fsm.c@681 
PS1, Line 681: 	if (!conn->lchan) {
I'd welcome a comment here explaining something similar to what you wrote in the commit description. It is not obvious at all why conn->lchan may be NULL here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25676
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3b1cd88bea62ef0032f6c035bac95d3df9fdca7a
Gerrit-Change-Number: 25676
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Oct 2021 09:30:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/82245eca/attachment.htm>


More information about the gerrit-log mailing list