Change in osmo-bsc[master]: Implement MS Uplink Power Control Loop

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Oct 4 08:59:29 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25654 )

Change subject: Implement MS Uplink Power Control Loop
......................................................................


Patch Set 11: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7//COMMIT_MSG@10 
PS7, Line 10: * Imports power_control.c from osmo-bts project.
> OK, Should it be the commit hash of the commit that originally adds power_control. […]
hash commit refernece is enough, like you did in newer version of the patch, thanks.


https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/include/osmocom/bsc/gsm_data.h@825 
PS7, Line 825: 	struct gsm_power_ctrl_meas_proc_state rxlev_meas_proc;
> Are you saying you would you like to see ms_power moved in here to '.current' in a separate patchset? (maybe previous to this one?) 

Yes, exactly. Not necessarily previous to this one, you can do that afterwards if you want (not mandatory but appreciated, thanks).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25654
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibc307e758697eb5ca3fb86622f35709d6077db9e
Gerrit-Change-Number: 25654
Gerrit-PatchSet: 11
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Oct 2021 08:59:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/5e2bc3e6/attachment.htm>


More information about the gerrit-log mailing list