Change in osmo-ttcn3-hacks[master]: f_TRXC_transceive(): accept 'template (value)' parameter

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25668 )


Change subject: f_TRXC_transceive(): accept 'template (value)' parameter
......................................................................

f_TRXC_transceive(): accept 'template (value)' parameter

Change-Id: I98012607f3e9da71234333aac77d59936cd3ee20
Related: OS#5245
---
M bts/BTS_Tests.ttcn
M library/TRXC_CodecPort.ttcn
2 files changed, 9 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/25668/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 616ca34..44d9de4 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -584,10 +584,10 @@
 		f_init_trxc(BTS_TRXC, id, g_bts_trxc_conn_id);
 
 		/* Start with a default moderate timing offset equalling TA=2, and RSSI=-60 */
-		ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_TIMING(2*256)));
-		ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_RSSI(-60)));
+		ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_TIMING(2*256));
+		ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_RSSI(-60));
 		/* OsmoBTS may have different AB / NB threshold (see MIN_QUAL_NORM, MIN_QUAL_RACH) */
-		ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_CI(60)));
+		ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_CI(60));
 	}
 
 	/* Wait some extra time to make sure the BTS emits a stable carrier.
@@ -708,12 +708,12 @@
 
 private function f_trxc_fake_rssi(TRXC_RSSI rssi) runs on ConnHdlr {
 	var TrxcMessage ret;
-	ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_RSSI(rssi)));
+	ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_RSSI(rssi));
 }
 
 private function f_trxc_fake_toffs256(int16_t toffs256) runs on ConnHdlr {
 	var TrxcMessage ret;
-	ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_TIMING(toffs256)));
+	ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_TIMING(toffs256));
 }
 
 /* first function started in ConnHdlr component */
@@ -1729,7 +1729,7 @@
 private function f_rach_toffs(int16_t toffs256, boolean expect_pass) runs on test_CT {
 	var TrxcMessage ret;
 	/* tell fake_trx to use a given timing offset for all bursts */
-	ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_TIMING(toffs256)));
+	ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_TIMING(toffs256));
 	f_sleep(0.5);
 
 	/* Transmit RACH request + wait for confirmation */
@@ -5391,8 +5391,7 @@
 	for (var int16_t i := -256; i <= 1280; i := i + 128) {
 		var TrxcMessage ret;
 
-		ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id,
-					 valueof(ts_TRXC_FAKE_CI(i)));
+		ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_CI(i));
 
 		/* FIXME: OsmoBTS may have different threshold (see MIN_QUAL_NORM) */
 		f_TC_pcu_data_ind_lqual_cb(i, thresh := 0);
diff --git a/library/TRXC_CodecPort.ttcn b/library/TRXC_CodecPort.ttcn
index 09b2977..bb2193f 100644
--- a/library/TRXC_CodecPort.ttcn
+++ b/library/TRXC_CodecPort.ttcn
@@ -59,7 +59,8 @@
 	msg := msg
 }
 
-function f_TRXC_transceive(TRXC_CODEC_PT pt, ConnectionId conn_id, TrxcMessage tx,
+function f_TRXC_transceive(TRXC_CODEC_PT pt, ConnectionId conn_id,
+			   template (value) TrxcMessage tx,
 			   template TrxcMessage tr := ?) return TrxcMessage {
 	var TRXC_RecvFrom rf;
 	timer T := 3.0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25668
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I98012607f3e9da71234333aac77d59936cd3ee20
Gerrit-Change-Number: 25668
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211003/fa2a1622/attachment.htm>