Change in libosmocore[master]: utils: remove misleading comments for osmo_hexdump[_nospc]_c()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Oct 2 21:13:15 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/25666 )


Change subject: utils: remove misleading comments for osmo_hexdump[_nospc]_c()
......................................................................

utils: remove misleading comments for osmo_hexdump[_nospc]_c()

The buffer is allocated dynamically on heap, so there is no such
limitation of 4096 bytes / 1365 characters.

Change-Id: I960dd6a53123fd4209ef6e61dcd0d22e4005e397
---
M src/utils.c
1 file changed, 0 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/25666/1

diff --git a/src/utils.c b/src/utils.c
index 2b21dcc..c180595 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -407,9 +407,6 @@
  *
  * This function will print a sequence of bytes as hexadecimal numbers,
  * adding one space character between each byte (e.g. "1a ef d9")
- *
- * The maximum size of the output buffer is 4096 bytes, i.e. the maximum
- * number of input bytes that can be printed in one call is 1365!
  */
 char *osmo_hexdump_c(const void *ctx, const unsigned char *buf, int len)
 {
@@ -446,9 +443,6 @@
  *
  * This function will print a sequence of bytes as hexadecimal numbers,
  * without any space character between each byte (e.g. "1aefd9")
- *
- * The maximum size of the output buffer is 4096 bytes, i.e. the maximum
- * number of input bytes that can be printed in one call is 2048!
  */
 char *osmo_hexdump_nospc_c(const void *ctx, const unsigned char *buf, int len)
 {

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25666
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I960dd6a53123fd4209ef6e61dcd0d22e4005e397
Gerrit-Change-Number: 25666
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211002/a34d74f0/attachment.htm>


More information about the gerrit-log mailing list