Change in osmo-ttcn3-hacks[master]: RSLEM: add f_chan_act_verify_tsc()

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25661 )


Change subject: RSLEM: add f_chan_act_verify_tsc()
......................................................................

RSLEM: add f_chan_act_verify_tsc()

Will need this code again to verify the TSC during handover, so cast
this in a separate function.

Related: SYS#4895
Change-Id: I7a3f68ed1deba6a4a0a1cc4df7613638225c1640
---
M library/RSL_Emulation.ttcn
1 file changed, 13 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/25661/1

diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index 30adfba..effe83b 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -136,6 +136,18 @@
 	return rx_rsl;
 }
 
+function f_chan_act_verify_tsc(RSL_Message chan_act, template uint3_t tsc) {
+	var RSL_IE_Body ie;
+	if (f_rsl_find_ie(chan_act, RSL_IE_CHAN_IDENT, ie)) {
+		var uint3_t got_tsc := ie.chan_ident.ch_desc.v.tsc;
+		if (not match(got_tsc, tsc)) {
+			setverdict(fail, "RSL CHANnel ACTIVation: unexpected TSC in Channel Description: expected ",
+				   tsc, " got ", got_tsc);
+			mtc.stop;
+		}
+	}
+}
+
 /* establish a dedicated channel using 'ra' */
 function f_chan_est(OCT1 ra, octetstring est_l3, template RslLinkId link_id, GsmFrameNumber fn := 23,
 		    template uint3_t tsc := ?, RSL_DCHAN_PT rsl_pt := RSL, RSLEM_PROC_PT rsl_proc_pt := RSL_PROC)
@@ -158,16 +170,7 @@
 	rsl_pt.send(ts_RSL_EST_IND(g_chan_nr, valueof(link_id), est_l3));
 
 	/* Check above CHAN ACTIV */
-	var RSL_Message chan_act := f_rslem_get_last_act(rsl_proc_pt, 0, g_chan_nr);
-	var RSL_IE_Body ie;
-	if (f_rsl_find_ie(chan_act, RSL_IE_CHAN_IDENT, ie)) {
-		var uint3_t got_tsc := ie.chan_ident.ch_desc.v.tsc;
-		if (not match(got_tsc, tsc)) {
-			setverdict(fail, "RSL CHANnel ACTIVation: unexpected TSC in Channel Description: expected ",
-				   tsc, " got ", got_tsc);
-			mtc.stop;
-		}
-	}
+	f_chan_act_verify_tsc(f_rslem_get_last_act(rsl_proc_pt, 0, g_chan_nr), tsc);
 }
 
 function f_deact_chan(RSL_Cause cause) runs on RSL_DchanHdlr

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25661
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7a3f68ed1deba6a4a0a1cc4df7613638225c1640
Gerrit-Change-Number: 25661
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211002/8b268bc3/attachment.htm>