This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
keith gerrit-no-reply at lists.osmocom.orgkeith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25653 ) Change subject: Add vty command to manually force MS Uplink Power ...................................................................... Patch Set 7: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25653/6/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25653/6/src/osmo-bsc/bsc_vty.c@1888 PS6, Line 1888: "bts <0-255> trx <0-255> timeslot <0-7> sub-slot <0-7> ms-power <5-40>\n", > are you sure 4-50 is the correct range or ms power levels? Oops, You're right, I principally work in the 850 band which has a minimum of 5 dB, but other bands have 0 dBm. As for the max, what I see in the spec is 39, for UE that supports it, in GSM 900 and GSM 850, but we have 0-40 in ms max power, so I shall use that range here. https://gerrit.osmocom.org/c/osmo-bsc/+/25653/6/src/osmo-bsc/bsc_vty.c@1896 PS6, Line 1896: if (!ts) > Add vty_out about wrong bts+trx+ts? OK, I was just following many other similar implementations. I think if one is running these bts x trx x commands, one is expected to know what bts and trx exist in the configuration. https://gerrit.osmocom.org/c/osmo-bsc/+/25653/6/src/osmo-bsc/bsc_vty.c@1908 PS6, Line 1908: lchan->ms_power = ms_pwr_ctl_lvl(ts->trx->bts->band, atoi(argv[4])); > What about reusing lchan_update_ms_power_ctrl_level() instead? You could extend that fucntion to ret […] Well, it is kind of designed for fuzzing, only to ever be executed by an operator who might expect things to break so yes, I'd say we don't want all those checks here. But lets add it as an option. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie2642299ea696358db5822571f1f722b5e8f76b9 Gerrit-Change-Number: 25653 Gerrit-PatchSet: 7 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 01 Oct 2021 23:11:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211001/5257b1f0/attachment.htm>