This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25653 ) Change subject: Add vty command to manually force MS Uplink Power ...................................................................... Patch Set 6: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25653/6/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25653/6/src/osmo-bsc/bsc_vty.c@1888 PS6, Line 1888: "bts <0-255> trx <0-255> timeslot <0-7> sub-slot <0-7> ms-power <5-40>\n", are you sure 4-50 is the correct range or ms power levels? https://gerrit.osmocom.org/c/osmo-bsc/+/25653/6/src/osmo-bsc/bsc_vty.c@1896 PS6, Line 1896: if (!ts) Add vty_out about wrong bts+trx+ts? https://gerrit.osmocom.org/c/osmo-bsc/+/25653/6/src/osmo-bsc/bsc_vty.c@1908 PS6, Line 1908: lchan->ms_power = ms_pwr_ctl_lvl(ts->trx->bts->band, atoi(argv[4])); What about reusing lchan_update_ms_power_ctrl_level() instead? You could extend that fucntion to return negative on error and return WARNIGN here in that case. I guess since this is a test command it's find yto bypass all the checks and send the value manually. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie2642299ea696358db5822571f1f722b5e8f76b9 Gerrit-Change-Number: 25653 Gerrit-PatchSet: 6 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 01 Oct 2021 09:23:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211001/28571136/attachment.htm>