Change in libosmo-netif[master]: stream: Factor out sctp_recvmg long code chunk

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Tue Nov 30 20:58:38 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26429 )

Change subject: stream: Factor out sctp_recvmg long code chunk
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/libosmo-netif/+/26429/1/src/stream.c 
File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/26429/1/src/stream.c@1333 
PS1, Line 1333: 			break;
The lint complains about this break, I don't agree with it though. Without we're one (or two) refactors away from an unintended fall-through


https://gerrit.osmocom.org/c/libosmo-netif/+/26429/1/src/stream.c@1358 
PS1, Line 1358: recvmg
recvm*s*g?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a
Gerrit-Change-Number: 26429
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 30 Nov 2021 20:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211130/6c0db4ef/attachment.htm>


More information about the gerrit-log mailing list