Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Nov 30 14:13:07 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 )

Change subject: Introduce osmo_prim_srv APIs
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c 
File src/prim.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c@1 
PS1, Line 1: #include <stdio.h>
could use some copyright / license header


https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c@39 
PS1, Line 39: osmo_prim_pkt_alloc
not sure what a prim_pkt is?   I don't think we've used this so far?

>From the body of the function it looks like a normal msgb-wrapped osmo_prim?


https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c@65 
PS1, Line 65: lcr
lcr?

also, this seems to imply that there can only be one client for every server?  I think we might need to split that up.  There are other existing unix-domain-socket using sub-systems that we may want to migrate that support multiple clients.  Also, especially some of those that I would expect that could be migrated (SCCP user SAP) support multiple users (clients) connected to one provider (server).



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044
Gerrit-Change-Number: 26426
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 30 Nov 2021 14:13:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211130/36574843/attachment.htm>


More information about the gerrit-log mailing list