Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Nov 30 13:16:10 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 )

Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c 
File src/libmsc/ran_msg_iu.c:

https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c@380 
PS2, Line 380: 			       | (1 << OSMO_UTRAN_UIA2);
(would prefer the comment on its own line, and replace "it" with something explanatory like "make the choice of available UIA algorithms configurable", if that's what you mean)


https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c@390 
PS2, Line 390: 					  (uia_mask << 1), /* API treats LSB as UIA0 */
> I think it's confusing using those values that way, because they are to be used in the protocol code […]
here I prefer the patch as-is, and also prefer keeping the value as in the spec. if we make up a "weird" bitmask then converting explicitly is best, i.e. exactly as it is in the patch.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a
Gerrit-Change-Number: 26410
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Nov 2021 13:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211130/1edd9b76/attachment.htm>


More information about the gerrit-log mailing list