Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Nov 30 08:30:34 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 )

Change subject: jobs/redmine-fetch: close issues on gerrit merge
......................................................................


Patch Set 4:

(5 comments)

> Patch Set 4:
> 
> (5 comments)
> 
> I think in general it would be better if we could have a textual config file containing the mappings of redmine project name vs. git repository.

Would we use this text file for something else? I could create an extra text file and put the mapping there, but I'm not sure if we should add the logic to fetch and interpret that if nothing else is using it. Isn't the mapping inside the jenkins job very readable and easy to update if needed?

Note that also this is for the special cases, it seems that newer projects are created with the same gerrit project name, redmine project name and redmine repository name. For OsmoHLR for example, no mapping entry is needed: https://osmocom.org/projects/osmo-hlr/repository/osmo-hlr

> Or, obviously, any method that doesn't require manually kept configuration which will soon be outdated as somebody forgets about it...

The jenkins job will fail if the URL downloaded at the end returns a 404. So if the mapping is wrong somewhere, or we add a new project that doesn't have the standard naming scheme, I will get a mail and can fix it. I think updating this mapping is low maintenance, and errors will get noticed quickly.

As mentioned in the commit message, I have considered other approaches too but they seemed like more effort. It is not like there's one redmine api call that lists all repositories in all projects.

https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml 
File jobs/redmine-fetch.yml:

https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml@45 
PS4, Line 45: libusrp
> libusrp could be secondary repo of osmo-trx?
I don't think I have all needed permissions to add them. For some redmine projects, I can edit the listed repositories. But they require a local path, and - following the existing naming scheme - /usr/local/git/repositories/libusrp.git does apparently not exist. When adding the repository as such, it gives a 404. Can you create those?


https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml@45 
PS4, Line 45: libgtpnl
> should be added as secondary repo to osmo-ggsn?
Same, /usr/local/git/repositories/libgtpnl.git does not exist


https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml@51 
PS4, Line 51: osmo-iuh
> this is certainly a but, the repository should be added to redmine
I've missed that it's here, patch updated: https://osmocom.org/projects/osmohnbgw/repository/osmo-iuh/


https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml@54 
PS4, Line 54: osmocom-lcs
> osmocom-lcs can be added as secondary repo to the osmo-bsc redmine project, in case there is no smlc […]
Added successfully to osmo-smlc: https://osmocom.org/projects/osmo-smlc/repository/osmocom-lcs


https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml@54 
PS4, Line 54: osmo-upf
> a related redmine project with repository should be created
There's a redmine project: https://osmocom.org/projects/osmo-upf

But I don't have permissions to modify the repositories.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027
Gerrit-Change-Number: 26423
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 30 Nov 2021 08:30:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211130/4ab9a17e/attachment.htm>


More information about the gerrit-log mailing list