Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Nov 30 07:42:28 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 )

Change subject: slot fsm: fake ccid setparameter response
......................................................................


Patch Set 5:

(1 comment)

If I read this correctly, you are preventing a PPS from happening by spoofing the response at CCID level.  Why is it then that the actual code performing PPS still needs to be modified?

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400/5/ccid_common/ccid_slot_fsm.c 
File ccid_common/ccid_slot_fsm.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400/5/ccid_common/ccid_slot_fsm.c@153 
PS5, Line 153: #ifndef __NOP
> there is no change here?
you go from __NOP() to __NOP ? at least that's what gerrit shows. Looks like somethign that should be in the previous commit?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2
Gerrit-Change-Number: 26400
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 30 Nov 2021 07:42:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211130/57d034dd/attachment.htm>


More information about the gerrit-log mailing list