Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 )

Change subject: Initial implementation of LowerLayer UD Socket
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/6/include/osmocom/hnodeb/hnb_prim.h 
File include/osmocom/hnodeb/hnb_prim.h:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/6/include/osmocom/hnodeb/hnb_prim.h@35 
PS6, Line 35: struct hnb_prim_hdr {
            : 	uint32_t sap;    /*!< Service Access Point Identifier */
            : 	uint32_t primitive;    /*!< Primitive number */
            : 	uint32_t operation; /*! Primitive Operation */
            : } __attribute__ ((packed));
maybe add a todo that this header should be moved to libosmocore as a general 'serialized osmo_prim header'?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/6/include/osmocom/hnodeb/hnodeb.h 
File include/osmocom/hnodeb/hnodeb.h:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/6/include/osmocom/hnodeb/hnodeb.h@57 
PS6, Line 57: chan_cs
I think 'connection' is more applicable than 'channel' here, as there is no notion of a 'channel' on Iu?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d
Gerrit-Change-Number: 26357
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 29 Nov 2021 20:45:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211129/c600b30e/attachment.htm>