Change in osmo-msc[master]: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 29 20:36:36 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26413 )

Change subject: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu()
......................................................................

libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu()

Change-Id: I42e819fb83096c1432df16f501b9d1f6a6160ae7
Fixes: I2c50904349dd4ed229b60b8468d776b817c0bd44
---
M src/libmsc/gsm_04_11.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  keith: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index bd7cf1f..722973e 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -642,7 +642,7 @@
 	 * attempt re-submission to the ESME)
 	 */
 	if (rc == GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER)
-		return rc;
+		goto out; /* free() the message */
 
 	/*
 	 * This SMS got routed through SMPP or no receiver exists.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26413
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I42e819fb83096c1432df16f501b9d1f6a6160ae7
Gerrit-Change-Number: 26413
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211129/0771ae30/attachment.htm>


More information about the gerrit-log mailing list