Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 29 20:36:35 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 )

Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu()
......................................................................

libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu()

If a MO SMS gets successfully routed through SMPP, we return early
in gsm340_rx_tpdu() and leak a chunk of type 'struct gsm_sms'.

Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228
Fixes: [1] Ic34d398e0a850856e20380ae35e5c2ae5e3c539b
Fixes: OS#5334
---
M src/libmsc/gsm_04_11.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  keith: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index 199fdc1..bd7cf1f 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -631,7 +631,8 @@
 
 	/* This SMS got routed through SMPP and we are waiting on the response. */
 	if (gsms->smpp.esme) {
-		return -EINPROGRESS;
+		rc = -EINPROGRESS;
+		goto out;
 	}
 
 	/* This SMS got routed through SMPP, but the configured ESME was

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228
Gerrit-Change-Number: 26411
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211129/f1143824/attachment.htm>


More information about the gerrit-log mailing list