Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 29 13:36:02 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 )

Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c 
File src/libmsc/ran_msg_iu.c:

https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c@390 
PS2, Line 390: 					  (uia_mask << 1), /* API treats LSB as UIA0 */
> Well, because it's cleaner than a magic number.
I think it's confusing using those values that way, because they are to be used in the protocol code, not in our bitmasks. You can still move that do and describe it with a comment:

const uint8_t uia_mas = 0x02 | 0x01; /* Allow UIA1 and UIA2. TODO: Make it configurable? */



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a
Gerrit-Change-Number: 26410
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Nov 2021 13:36:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211129/0d085cc2/attachment.htm>


More information about the gerrit-log mailing list