This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 )
Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu()
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c@633
PS1, Line 633: if (gsms->smpp.esme) {
> Are you sure it is leaked if it got routed? It could be that the sms is added to some wqueue or simi […]
Nope, I spent quite some time checking the code branches. The given 'gsms' is merely used to compose an SMPP message, but never gets free()d or queued. And actually we did free() it before Ic34d398e0a850856e20380ae35e5c2ae5e3c539b was merged.
https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c@644
PS1, Line 644: if (rc == GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER)
> Will you upload another patchset?
https://gerrit.osmocom.org/c/osmo-msc/+/26413
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228
Gerrit-Change-Number: 26411
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Nov 2021 12:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211129/2bb7b3d0/attachment.htm>