Change in docker-playground[master]: ttcn3-*-test/jenkins.sh: write the SUT's PID to /tmp/sut.pid

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Nov 29 11:56:22 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 )

Change subject: ttcn3-*-test/jenkins.sh: write the SUT's PID to /tmp/sut.pid
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/docker-playground/+/26408/1/ttcn3-bsc-test/jenkins.sh 
File ttcn3-bsc-test/jenkins.sh:

https://gerrit.osmocom.org/c/docker-playground/+/26408/1/ttcn3-bsc-test/jenkins.sh@46 
PS1, Line 46: docker exec	${BUILD_TAG}-bsc "pidof osmo-bsc > /tmp/sut.pid"
Hey Oliver,

thanks for your feedback! I haven't tested this patch yet, it's more like a proposal (forgot to make it WIP).

> exec: "pidof osmo-bsc > /tmp/sut.pid": stat pidof osmo-bsc > /tmp/sut.pid: no such file or directory: unknown

Ah, for some reason Docker treats the command as a file, because of the quotes. If I remove them, it seems to work.

> I think this is a race condition, osmo-bsc may not have started at this point?

Could be the case, but then pidof would simply return nothing.

> However, the SUT runs in a different docker container than the testsuite. It uses a different pid namespace, so ttcn3-tcpdump-stop.sh can't run "kill -s USR1". At least in my setup it doesn't work, osmo-bsc has pid 7 in its own container, and then running in the testsuite docker container:

Good point. This renders the current approach wrong.

> Maybe an alternative approach could be to get the talloc report via ttcn-3 + CTRL/VTY port right before closing that connection at the end of the test, and print it there / write it to a file with the test name? 

Yep, I am also thinking of this approach.



-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163
Gerrit-Change-Number: 26408
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Nov 2021 11:56:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211129/61261508/attachment.htm>


More information about the gerrit-log mailing list