Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Nov 27 23:14:14 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 )

Change subject: ipaccess-config: improve readability of printed attribute response
......................................................................


Patch Set 2: Verified+1

> Patch Set 2: Code-Review+1
> 
> AFAIR pespin had some concerns about osmo-gsm-tester relying on existing output, please do a grep in the osmo-gsm-tester repo to find out and make sure it is updated, too.

I checked the code, and as far as I can see we parse the output using Python's JSON library. I just fixed trailing commas in my code, so the parser is happy. I also did some tests, and everything appears to work fine.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876
Gerrit-Change-Number: 26149
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: roox <mardnh at gmx.de>
Gerrit-Comment-Date: Sat, 27 Nov 2021 23:14:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211127/5635834e/attachment.htm>


More information about the gerrit-log mailing list