Change in libosmocore[master]: logging: make LIBOSMOCORE_NO_LOGGING work as expected

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Nov 27 14:52:03 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26394 )

Change subject: logging: make LIBOSMOCORE_NO_LOGGING work as expected
......................................................................


Patch Set 1:

I think you are confusing two different things:

a) disabling logging altogether (this is new)
b) disabling only DEBUG level logging while keeping the higher level logging

'b' was what I had originally in mind with the DEBUG define when writing the logging code ages ago, and which is also what I believe you recently wanted to support by an external #define?

In any case, whatever we do, the existence of the "DEBUG" #define should only toggle LOGL_DEBUG / DEBUGP and not normal LOGP calls.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26394
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585
Gerrit-Change-Number: 26394
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 27 Nov 2021 14:52:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211127/8dc49c0f/attachment.htm>


More information about the gerrit-log mailing list