Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sat Nov 27 03:32:51 UTC 2021


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 )


Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2()
......................................................................

ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2()

Since ranap_new_msg_sec_mod_cmd2() doesn't support UEA0 we must not pass it to it.
The reason behind is that UEA0 can't passed in the TLV of a SecurityCommand and is implicit
UEA0 if the TLV is not present.

Fixes: 505a94a610fc ("Make UTRAN encryption algorithms configurable")
Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e
---
M src/libmsc/ran_msg_iu.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/91/26391/1

diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c
index 8ffdd93..9a37e5c 100644
--- a/src/libmsc/ran_msg_iu.c
+++ b/src/libmsc/ran_msg_iu.c
@@ -382,7 +382,7 @@
 	/* TODO: Do we need to check if the UE supports all of the algorithms and build an intersection like
 	 * in the case of A5? */
 	return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) ? cm->vec->ck : NULL,
-					  RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask);
+					  RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask & ~(1 << OSMO_UTRAN_UEA0));
 }
 
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e
Gerrit-Change-Number: 26391
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211127/4d8659d7/attachment.htm>


More information about the gerrit-log mailing list