Change in osmo-bsc[master]: stats: add bsc.paging:expired

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Nov 26 23:11:04 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 )

Change subject: stats: add bsc.paging:expired
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > Then why not having some sort of per-paging-req counter which is incremented for each BTS where it is scheduled, and decreased when it expires?
> > Then if all fail and reaches 0, the expired counter is incremented. If one succeeds, the refcound is dropped.
> 
> So in other words (to make sure I understood you correctly):
> * instead of bsc_T3113, add a counter of active pagings to struct bsc_subscr
> * decrease by 1 if one BTS paging fails
> * if it is going from 1 to 0 because a BTS failed, also increase bsc.paging:expired
> * if paging is successful for any BTS, set it to 0, don't increase bsc.paging:expired
> 

ACK

> Should work as well. What's the advantage over the approach in the current patch?

Not having an extra timer made up of several timers for each paging in process.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d
Gerrit-Change-Number: 26384
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Nov 2021 23:11:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211126/39d808f5/attachment.htm>


More information about the gerrit-log mailing list