Change in libosmocore[master]: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Nov 25 14:43:14 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmocore/+/26365

to look at the new patch set (#2).

Change subject: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg()
......................................................................

gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg()

gsmtap_sendmsg() places the burden of freeing the msgb in case of
erroneous return codes on the caller.  A review of existing users
shows that this is overly optimistic and many calls get it wrong,
opening up memory leaks.

Let's add a new function gsmtap_sendmsg_free() which behaves like
gsmtap_sendmsg() but always takes ownership: Either it is sent + freed,
or it is just freed.

Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5
Related: OS#5329
---
M include/osmocom/core/gsmtap_util.h
M src/gsmtap_util.c
2 files changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/26365/2
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26365
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5
Gerrit-Change-Number: 26365
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211125/77f56c63/attachment.htm>


More information about the gerrit-log mailing list