This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 6: Probably I did not understand this correctly. I guess you mean that the dropping/rejecting should be done from osmo_bsc_main.c:inp_sig_cb. I have tried that, but all I get a segfault then. That is why I opted to do the rejecting from abis_nm.c:abis_nm_rcvmsg_fom A sign_link_up callback seems only to exist for ipaccess BTSs. So it seems logical to execute ipaccess_drop_oml() of the BTS from there as well. Surprisingly this does not work either. The problem now is that osmo_bsc_main.c:inp_sig_cb does not get the S_L_INP_TEI_UP event anymore, so the config is not re-checked and the BTS is permanently rejected. What we could do is to execute the check from bts_ipaccess_nanobts.c:ipaccess_sign_link_up() once more. Then it should work. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 25 Nov 2021 11:10:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211125/8f96720f/attachment.htm>