Change in libosmocore[master]: logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LO...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Nov 24 21:48:00 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26356 )

Change subject: logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LOGGING
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/26356/1/include/osmocom/core/logging.h 
File include/osmocom/core/logging.h:

https://gerrit.osmocom.org/c/libosmocore/+/26356/1/include/osmocom/core/logging.h@20 
PS1, Line 20: #endif
style-wise I would have done 

#ifndef LIBOSMOCORE_NO_LOGGING
#ifndef DEBUG
#define DEBUG
#endif
#endif

but I guess your version is equally understandable.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26356
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I589f93d98a6bc5cf6221c56e2fe3f27bfdd200e8
Gerrit-Change-Number: 26356
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 24 Nov 2021 21:48:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211124/5b23b55d/attachment.htm>


More information about the gerrit-log mailing list