Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix crash if !conn

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26350 )

Change subject: bsc_subscr_conn_fsm: fix crash if !conn
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/26350/2/src/osmo-bsc/bsc_subscr_conn_fsm.c 
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/26350/2/src/osmo-bsc/bsc_subscr_conn_fsm.c@524 
PS2, Line 524: 	if (conn && conn->user_plane.mgw_endpoint)
I'd rather do a:
if (!conn) { log("no conn!") + return}

This way code is clearer and doesn't look like a cascade of lucky check-against-nulls going through and returning at the end. Furthermore, we get a specific log line which is descriptive and not misleading like ""Conn is neither SCCPlite nor AoIP!?\n", because there's really no conn.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf
Gerrit-Change-Number: 26350
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Nov 2021 13:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211124/cec3d50f/attachment.htm>