Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 )

Change subject: hnb: Introduce HNB_Tests testsuite
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn 
File library/Iuh_Emulation.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn@156 
PS1, Line 156: 		v
seems like an unused variable?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn@159 
PS1, Line 159: 		v
likewise, unused variable?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn@174 
PS1, Line 174: MME
no MME involved in 3G


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn@194 
PS1, Line 194: 		[] Iuh.receive(ASP_Event:{connOpened:=?}) -> value asp_evt {
if those are server-only, it might make sense to use a guard expression to constrain the clause to the server case.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Types.ttcn 
File library/Iuh_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Types.ttcn@45 
PS1, Line 45: type record Iuh_PDU {
            : 	Iuh_MsgType	pdu_type,
            : 	Iuh_PDUUnion	u
            : } with {
            : 	variant (u) "CROSSTAG(hnbap, pdu_type = IUH_MSG_TYPE_HNBAP;
            : 			      rua, pdu_type = IUH_MSG_TYPE_RUA;
            : 			      payload, OTHERWISE)"
            : };
I'm not quite sure about what you're doing here.  In the wire encoding of the 3GPP specifications, do we ever have such a header as you describe here? with a pdu_type octet followed by that union?   If not, then the "pdu_type" is useless, as unlike in C, a union in TTCN3 carries implicit knowledge about whihc of the alternatives is selected.

Any code wanting to know which of the Iuh_PDUUnion alternatives is used in a given variable can use ischosen(foo.hnbap) or the like.

Yes, you can of course add an explicit pdu_type, but I think it is not "native" TTCN3 programming, and it just makes the code more complex without any benefit.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7
Gerrit-Change-Number: 26336
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 23 Nov 2021 10:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211123/4c25a629/attachment.htm>