This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py@48 PS5, Line 48: def select_app(adf:str): > I think 'card' should be passed as an argument to the function and not rely on a global variable Sorry for the bike shedding, but I agree. Doesn't it make sense to have this as a method on the Card class and then call card.select_app()? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: daniel <dwillmann at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 23 Nov 2021 10:39:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211123/8674fc26/attachment.htm>