Change in osmo-qcdiag[master]: protocol: fix: properly declare value_string arrays

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 )

Change subject: protocol: fix: properly declare value_string arrays
......................................................................

protocol: fix: properly declare value_string arrays

Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef
---
M src/protocol/diag_log_gprs_l1.h
M src/protocol/diag_log_gsm.h
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  dexter: Looks good to me, approved
  fixeria: Verified



diff --git a/src/protocol/diag_log_gprs_l1.h b/src/protocol/diag_log_gprs_l1.h
index eee9632..8f8585c 100644
--- a/src/protocol/diag_log_gprs_l1.h
+++ b/src/protocol/diag_log_gprs_l1.h
@@ -72,7 +72,7 @@
 	DIAG_TX_UL_CH_T_UL_PTCCH,
 	DIAG_TX_UL_CH_T_UL_PACCH_PDTCH,
 };
-const struct value_string gprs_tx_ul_chans[4];
+extern const struct value_string gprs_tx_ul_chans[4];
 
 enum gprs_coding_scheme {
 	DIAG_GPRS_CS_CS1,
@@ -91,7 +91,7 @@
 	DIAG_GPRS_CS_MCS8,
 	DIAG_GPRS_CS_MCS9,
 };
-const struct value_string gprs_coding_schemes[16];
+extern const struct value_string gprs_coding_schemes[16];
 
 struct gprs_tx_sched_res {
 	uint32_t	fn;
diff --git a/src/protocol/diag_log_gsm.h b/src/protocol/diag_log_gsm.h
index 378472f..d382f1a 100644
--- a/src/protocol/diag_log_gsm.h
+++ b/src/protocol/diag_log_gsm.h
@@ -192,7 +192,7 @@
 	DIAG_GPRS_LLMES_TLLI_ASS	= 1,
 	DIAG_GPRS_LLMES_TEST_MODE	= 2,
 };
-const struct value_string diag_gprs_llme_st_vals[4];
+extern const struct value_string diag_gprs_llme_st_vals[4];
 
 /* LOG_GPRS_LLC_ME_INFO_C */
 struct diag_gprs_llme_info {
@@ -282,7 +282,7 @@
 	DIAG_SAPI0_ST_LINK_SUSP,
 	DIAG_SAPI0_ST_UA_PEND,
 };
-const struct value_string diag_gsm_l2_sapi0_st_vals[10];
+extern const struct value_string diag_gsm_l2_sapi0_st_vals[10];
 
 enum diag_gsm_sapi3_state {
 	DIAG_SAPI3_ST_NULL,
@@ -294,7 +294,7 @@
 	DIAG_SAPI3_ST_TMR_RECOV,
 	DIAG_SAPI3_ST_UA_PEND,
 };
-const struct value_string diag_gsm_l2_sapi3_st_vals[9];
+extern const struct value_string diag_gsm_l2_sapi3_st_vals[9];
 
 enum diag_gsm_l2_event {
 	DIAG_L2_EV_NO_EVENT,
@@ -325,7 +325,7 @@
 	DIAG_L2_EV_UA_SENT,
 	DIAG_L2_EV_FORCED_SUSPEND_REQ,
 };
-const struct value_string diag_gsm_l2_event_vals[28];
+extern const struct value_string diag_gsm_l2_event_vals[28];
 
 struct diag_gsm_l2_state {
 	uint8_t sapi;
@@ -343,7 +343,7 @@
 	DIAG_L2_CHT_FACCH_F	= 6,
 	DIAG_L2_CHT_FACCH_H	= 7,
 };
-const struct value_string diag_gsm_l2_chantype_vals[9];
+extern const struct value_string diag_gsm_l2_chantype_vals[9];
 
 struct diag_gsm_l2_transm_status {
 	uint8_t sapi;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-qcdiag
Gerrit-Branch: master
Gerrit-Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef
Gerrit-Change-Number: 26326
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211119/bd19d0a6/attachment.htm>