Change in libosmocore[master]: bssgp_bvc_fsm: Move log message to the correct place

[daniel]

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26331 )

Change subject: bssgp_bvc_fsm: Move log message to the correct place
......................................................................

bssgp_bvc_fsm: Move log message to the correct place

The log message is very confusing if printed for PtP-BVCI as well. Move
it into the correct if branch.

Change-Id: I0359443ddc52108b492f741005c4699e06b40183
---
M src/gb/bssgp_bvc_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c
index ce9079d..664ad09 100644
--- a/src/gb/bssgp_bvc_fsm.c
+++ b/src/gb/bssgp_bvc_fsm.c
@@ -415,8 +415,8 @@
 		rx = data;
 		tp = (const struct tlv_parsed *) msgb_bcid(rx);
 		/* If BVC-UNBLOCK-ACK PDU is received by an BSS for the signalling BVC, the PDU is ignored. */
-		LOGPFSML(fi, LOGL_ERROR, "Rx BVC-UNBLOCK-ACK on BVCI=0 is illegal\n");
 		if (bfp->bvci == 0) {
+			LOGPFSML(fi, LOGL_ERROR, "Rx BVC-UNBLOCK-ACK on BVCI=0 is illegal\n");
 			if (!bfp->role_sgsn)
 				break;
 			_tx_status(fi, BSSGP_CAUSE_SEM_INCORR_PDU, rx);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26331
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0359443ddc52108b492f741005c4699e06b40183
Gerrit-Change-Number: 26331
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211119/0637635b/attachment.htm>