This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Hoernchen gerrit-no-reply at lists.osmocom.orgHoernchen has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26329 ) Change subject: fix isdigit taking unsigned as input ...................................................................... fix isdigit taking unsigned as input gcc complains because our char might or might not be signed depending on arch and phase of the moon: error: array subscript has type 'char' [-Werror=charsubscripts] Change-Id: I7c76f9a2318c4f0e5eedeea00ec380824b86567e --- M src/utils.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Hoernchen: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/utils.c b/src/utils.c index 626dcb4..300204a 100644 --- a/src/utils.c +++ b/src/utils.c @@ -1250,7 +1250,7 @@ if (point) return -EINVAL; point = p; - } else if (!isdigit(*p)) + } else if (!isdigit((unsigned char)*p)) return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7c76f9a2318c4f0e5eedeea00ec380824b86567e Gerrit-Change-Number: 26329 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211119/517786c8/attachment.htm>