This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 ) Change subject: MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() ...................................................................... MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() Change-Id: Iefef18b7f6330dbfb61a98c8c037c9c904cf0c24 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index cb93bfe..481abc0 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -840,26 +840,28 @@ var BIT5 inp := ch_desc.channelTypeandTDMAOffset; var uint3_t tn := bit2int(ch_desc.timeslotNumber); - if (match(inp, '00001'B)) { /* TCH/F */ + select (inp) { + case ('00001'B) { /* TCH/F */ chan_nr := valueof(t_RslChanNr_Bm(tn)); - } - else if (match(inp, '11101'B)) { /* VAMOS TCH/F */ + } + case ('11101'B) { /* VAMOS TCH/F */ chan_nr := valueof(t_RslChanNr_Osmo_VAMOS_Bm(tn)); - } - else if (match(inp, '0001?'B)) { /* TCH/H */ + } + case ('0001?'B) { /* TCH/H */ chan_nr := valueof(t_RslChanNr_Lm(tn, bit2int(substr(inp, 4, 1)))); - } - else if (match(inp, '1111?'B)) { /* VAMOS TCH/H */ + } + case ('1111?'B) { /* VAMOS TCH/H */ chan_nr := valueof(t_RslChanNr_Osmo_VAMOS_Lm(tn, bit2int(substr(inp, 4, 1)))); - } - else if (match(inp, '001??'B)) { /* SDCCH/4 */ + } + case ('001??'B) { /* SDCCH/4 */ chan_nr := valueof(t_RslChanNr_SDCCH4(tn, bit2int(substr(inp, 3, 2)))); - } - else if (match(inp, '01???'B)) { /* SDCCH/8 */ + } + case ('01???'B) { /* SDCCH/8 */ chan_nr := valueof(t_RslChanNr_SDCCH8(tn, bit2int(substr(inp, 2, 3)))); - } - else { + } + case else { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unknown ChDesc!"); + } } if (ch_desc.octet3 and4b '10'O == '10'O) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iefef18b7f6330dbfb61a98c8c037c9c904cf0c24 Gerrit-Change-Number: 26321 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211118/aace4bae/attachment.htm>