Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Nov 18 17:07:01 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 )

Change subject: rework the counters and stats so they work with the threaded mgw
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c@322 
PS10, Line 322: 		LOGP(DLMGCP, LOGL_ERROR, "msg too short: %zd\n", rc);
> why has this changed to print rc, which is uniniaitlized?
isn't it initialized by ssize_t rc, msglen = w->x.msglen;?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0
Gerrit-Change-Number: 26190
Gerrit-PatchSet: 10
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Nov 2021 17:07:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211118/97977ebc/attachment.htm>


More information about the gerrit-log mailing list