Change in osmo-gbproxy[master]: gbproxy: Fix error return value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Thu Nov 18 14:35:06 UTC 2021


daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318 )


Change subject: gbproxy: Fix error return value
......................................................................

gbproxy: Fix error return value

OSMO_TLVP_ERR_MAND_IE_MISSING is already negative

Change-Id: I17e438be50324684cebe0852ecab877097bb0cbb
---
M src/gb_proxy.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/18/26318/1

diff --git a/src/gb_proxy.c b/src/gb_proxy.c
index 3d76a33..6fd6f77 100644
--- a/src/gb_proxy.c
+++ b/src/gb_proxy.c
@@ -388,7 +388,7 @@
 	if (bgph->pdu_type == BSSGP_PDUT_UL_UNITDATA || bgph->pdu_type == BSSGP_PDUT_DL_UNITDATA) {
 		const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) bgph;
 		if (msg_len < sizeof(*budh))
-			return -OSMO_TLVP_ERR_MAND_IE_MISSING;
+			return OSMO_TLVP_ERR_MAND_IE_MISSING;
 		rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp, 1, budh->pdu_type, budh->data,
 					 msg_len - sizeof(*budh), 0, 0, DGPRS, log_pfx);
 		/* populate TLLI from the fixed headser into the TLV-parsed array so later code

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I17e438be50324684cebe0852ecab877097bb0cbb
Gerrit-Change-Number: 26318
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211118/8f5cbcb4/attachment.htm>


More information about the gerrit-log mailing list