This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Hoernchen gerrit-no-reply at lists.osmocom.orgHoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 )
Change subject: Add multithreading for the virtual trunk
......................................................................
Patch Set 35:
(2 comments)
https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h
File include/osmocom/mgcp/mgcp_trunk.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h@30
PS35, Line 30: unsigned int
> why is this broken into 2 lines?
because the useless comments are too long and this is kernel style formatting
https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/osmo-mgw/mgw_main.c
File src/osmo-mgw/mgw_main.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/osmo-mgw/mgw_main.c@326
PS35, Line 326: {
> This was changed to a new line but the code style specs it to be in the same one in for loops.
you got to be fucking kidding?!
we've had kernel style formatting for for-like macros before, then you complained because we don't do kernel style formatting, so now it's formatted automagically without for-like macros according to kernel style rules, and now that is the problem?
either we apply formatting rules and stop discussing or we keep finding new ways not to apply formatting rules and discuss this until eternity.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260
Gerrit-Change-Number: 25432
Gerrit-PatchSet: 35
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 18 Nov 2021 14:09:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211118/17a8ae96/attachment.htm>