Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 )

Change subject: rework the counters and stats so they work with the threaded mgw
......................................................................


Patch Set 9:

(3 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/include/osmocom/mgcp/mgcp_trunk.h 
File include/osmocom/mgcp/mgcp_trunk.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/include/osmocom/mgcp/mgcp_trunk.h@29 
PS9, Line 29: 	atomic_int_least32_t thread_ready_counter; /* used to check if all child trunk threads are ready for action */
This is only used by the top trunk right? But this struct is duplicated for each thread iirc?


https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c 
File src/libosmo-mgcp/mgcp_threads.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c@440 
PS9, Line 440: 	{
same line


https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c@498 
PS9, Line 498: 		while (trunk->use_threads && trunk->thread_ready_counter != num_threads)
iiuc there's no need to check trunk->us_threads here? or is num_threads 1 when we run in single thread?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0
Gerrit-Change-Number: 26190
Gerrit-PatchSet: 9
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Nov 2021 09:59:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211118/3cdec649/attachment.htm>